Skip to content

GitHub Tracker by Birgit Nehrwein#23

Open
nehrwein wants to merge 19 commits intoTechnigo:mainfrom
nehrwein:main
Open

GitHub Tracker by Birgit Nehrwein#23
nehrwein wants to merge 19 commits intoTechnigo:mainfrom
nehrwein:main

Conversation

@nehrwein
Copy link
Copy Markdown

@nehrwein nehrwein commented Oct 2, 2021

No description provided.



getRepos();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love our code Birgit and it was so interesting on Friday when you showed it to the group. I think you made an awesome site!!! The implementation of an accordion is just the next level of the project! everything seems to work fine the only trouble I have is whit the sorting function (the name sorting is not working for me). That's not a mandatory feature so if you don't have the time not bother to fix it! You and I did solve some functions in different ways and it is really fun to see our solutions, the code is easy to read and understand!

[YES ] Am I able to understand the code easily?
[NO ] Does the code have lots of duplicates? Could it be tidied up?
[ works ] Does it work or does anything look broken?
[Yes and above! ] Does it follow the general and blue requirements?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hej Jessica,
thank you so much for your kind review! 👍
And thanks for pointing out, that the sorting isn't working. I will have a look at it again. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant