Conversation
Kaliine
left a comment
Kaliine
left a comment
There was a problem hiding this comment.
First of all - your site looks great and I believe you have fulfilled all blue requirements! The responsive design works perfectly and all API fetches are doing their job. Your code is clean and easy to follow - good comments both in JS and CSS. Great job!
code/script.js
Outdated
| // project container | ||
| projectsContainer.innerHTML += ` | ||
| <div class="repo"> | ||
| <a href="${repo.clone_url }" target="_blank"><h3>${repo.name}</h3> </a> |
There was a problem hiding this comment.
I'm curious - is there a reason why you link to the clone_url instead of the html_url?
code/style.css
Outdated
|
|
||
|
|
||
| /* navbar */ | ||
|
|
There was a problem hiding this comment.
It's great that you leave comments in the style.css as well! Very helpful when someone else is reading your code.
code/style.css
Outdated
| } | ||
|
|
||
| form.example input[type=text] { | ||
| padding: 17px; |
There was a problem hiding this comment.
Did you remove your search function? Consider removing the styling for it, or comment it out.
code/style.css
Outdated
| /* Style the submit button */ | ||
| form.example button { | ||
| float: left; | ||
| width: 30%; |
There was a problem hiding this comment.
'Float' is a new property to me, I learnt something here. That will be useful!
README.md
Outdated
| @@ -10,4 +10,4 @@ Describe how you approached to problem, and what tools and techniques you used t | |||
|
|
|||
There was a problem hiding this comment.
Remember to describe your project in the Readme file.
2 participants
No description provided.