Project GitHub tracker, Elin Diczfalusy w7 - #19
Open
Ajliin wants to merge 13 commits into
Open
Conversation
added 13 commits
September 27, 2021 16:58
Lundgreneddie
approved these changes
Oct 10, 2021
Lundgreneddie
left a comment
Lundgreneddie
left a comment
There was a problem hiding this comment.
Really good job, other than 2 console logs I can't come up with anything you could have done better! :D
Comment on lines
+33
to
+37
| // ------------function filters out the forked repos from Technigo | ||
| const forkedRepo = data.filter((repo) => repo.fork && repo.name.startsWith('project-')) | ||
| // ------------function to chart.js on how many repos | ||
| drawChart(forkedRepo.length) | ||
| // ------------forEach repo --> send to innerHTML |
There was a problem hiding this comment.
Good job on the amount of comments on your code in general, so easy to follow and understand what everything does! :)
|
|
||
| //"Draw" the chart here 👇 | ||
| //'Draw' the chart here 👇 | ||
| console.log('Pie chart is here') |
| fetchCommits(myPullRequest.url, project.name) | ||
|
|
||
| }else{ | ||
| console.log('else part in function works', myPullRequest) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All comments in ReadMe