project-github-tracker-justine#115
Conversation
| </head> | ||
| <body> | ||
| <div id="profile" class="profile"></div> | ||
| <img src="images/bag.png" alt="a bag of repos" class="img-bag" /> |
There was a problem hiding this comment.
LOVE this. Did you create it yourself?
There was a problem hiding this comment.
Ah thanks! I made it in Canva!
| <div class="wave"></div> | ||
| <div id="repoGrid" class="repo-grid"></div> | ||
| <div class="wave"></div> |
| @@ -0,0 +1,78 @@ | |||
| // DOM selectors: | |||
| const repoGrid = document.getElementById("repoGrid"); | |||
There was a problem hiding this comment.
I like how you name the variables. Easy to read!
| const API_REPOS = `https://api.github.com/users/${userName}/repos`; | ||
|
|
||
| // Profile information function: | ||
| const getProfile = () => { |
There was a problem hiding this comment.
Clean code, mine were a lot messier haha. Great job!
| getRepos(); | ||
| }; | ||
|
|
||
| // Fetch repositories function: |
| }); | ||
| }; | ||
|
|
||
| // Fetch pull requests function: |
There was a problem hiding this comment.
I had a hard time with this one. Yours was a lot easier to read! Thanks for clearing things up in my head with the comments
| ) | ||
| .then((res) => res.json()) | ||
| .then((data) => { | ||
| const myPullsOnly = data.find( |
| body { | ||
| background: #FFECE9; | ||
| } No newline at end of file | ||
| * { |
There was a problem hiding this comment.
Great with *, I haven't added that in mine, I always use body for that. Thanks!
|
|
||
| /* Profile information: */ | ||
| .profile { | ||
| background-color: pink; |
| background-position: 0; | ||
| background-size: auto 100%; | ||
| background-repeat: repeat-x; | ||
| animation: animateCloud 20s linear infinite; |
There was a problem hiding this comment.
Such a cool animation! Where did you find the wave-picture?
| } | ||
|
|
||
| /* Tablet */ | ||
| @media screen and (min-width: 600px) and (max-width: 992px) { |
| object-fit: cover; | ||
| animation: shake 2s infinite; | ||
| } | ||
| @keyframes shake { |
emmajosefina
left a comment
emmajosefina
left a comment
There was a problem hiding this comment.
I adore your page, Justine! It looks very professional. You have made a page that's functional, responsive and fulfills all the requirement for blue level. Also I love your repo bag and animation, really great job! So impressed by your performance this week :)
|
Thank you for your kind words Emma! |
2 participants
No description provided.