Sarah Mottram - project-github-tracker#10
Conversation
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Sara's code for github-tracker project was very clean and easy to read, really honing in that 'write it like a children's book' principle. I learned some new techniques such as !important property in CSS and how to make the if or else statement clean and easy to read. Thanks Sara!
| return pullsData.find((pull) => pull.user.login === "anndimi"); | ||
| } else { | ||
| return pullsData.find((pull) => pull.user.login === username); | ||
| } |
There was a problem hiding this comment.
Clever way to distinguish the repos that were forked from certain id's repository!
|
|
||
| const createHTMLForRepo = (repo) => { | ||
| return `<a target="blank" href="${repo.html_url}" class="repo-container ${ | ||
| repo.language |
There was a problem hiding this comment.
Can I ask what does this <repo. language> do in the code? Maybe I am missing something that is actually quite obvious, but was curious what this code means.
| "<p>No pull request made yet</p>"; | ||
| } else { | ||
| fetchCommits(myPullRequest.commits_url, repo.name); | ||
| } |
There was a problem hiding this comment.
Your 'if/ else' code usage throughout the whole code is so clear and easy to read, thanks! I get really clumsy when I write if or else statement, so I find these so satisfying and skillful.
| ).innerHTML += `<p>Number of commits: ${ | ||
| data.length | ||
| }</p><p>Last commit message: ${data[data.length - 1].commit.message}</p>`; | ||
| }); |
| .hero-image { | ||
| background: linear-gradient(rgba(0, 0, 0, 0.342), rgba(0, 0, 0, 0.774)), | ||
| url("./Images/GitHub-headpic.jpeg"); | ||
| height: 50vh; |
There was a problem hiding this comment.
I am curious what is the benefit of using vh units instead of px or em! Any reasons you preferred this?
| main { | ||
| grid-template-columns: repeat(3, 1fr); | ||
| } | ||
| } |
There was a problem hiding this comment.
Very clean and efficient responsive css code!
1 participant
I've just focussed on the blue requirements for this week. I found it quite challenging to 'forget' about the CSS and try some of the red/black goals, so I might come back to these at a later date, but for now I'm happy with how far I got with this project.