Skip to content

Comments

auto detect video sites and check its status#59

Merged
Stigmatoz merged 1 commit intoStigmatoz:all-sites-video-trackingfrom
luc99hen:videoSite
Jan 17, 2022
Merged

auto detect video sites and check its status#59
Stigmatoz merged 1 commit intoStigmatoz:all-sites-video-trackingfrom
luc99hen:videoSite

Conversation

@luc99hen
Copy link

@luc99hen luc99hen commented Jan 7, 2022

This PR is based on the issue #4.

Changes:

  • remove YT/Netflix logic
  • auto detect video sites and track its status accordingly (This need an extra "all_urls" permission)

@Stigmatoz
Copy link
Owner

Hi, Luc.
These are very cool and useful changes. But I can't publish these changes to the chrome store, because it requires the "<all_urls>" permissions to be applied. A long time ago I made the same changes and then many people removed extensions because they are afraid theat the extension needs acceess to all sites.

@luc99hen
Copy link
Author

luc99hen commented Jan 17, 2022

Thank you for your reply.
Totally understand the concerns of privacy from this change😆.
Maybe we can create another branch from this change, in case someone else want this feature?

@Stigmatoz Stigmatoz changed the base branch from master to all-sites-video-tracking January 17, 2022 12:29
@Stigmatoz Stigmatoz merged commit b477359 into Stigmatoz:all-sites-video-tracking Jan 17, 2022
@Stigmatoz
Copy link
Owner

Yes, I made a new branch all-sites-video-tracking and approved pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants