Fix race condition with setting current tab#54
Merged
Stigmatoz merged 1 commit intoStigmatoz:masterfrom Oct 11, 2021
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chrome.windows.getLastFocuseddrops focus for the current window when the extension is opened to show the chart. This causes a race condition where the current tab is most likely cleared out by the time the chart is displayed. The fix is to allow preservingcurrentTabwhen closing the time interval.activity.clearCurrentActiveTabas it is unused.setActiveTooltipto correctly find tooltip by host.