Skip to content

Commit 2247a36

Browse files
fix: improve RH panel behavior at small viewport sizes (ietf-tools#3801)
* fix: align nav links to top of RH panel * fix: allow timezone picker to wrap * fix: improve RH panel behavior at small viewport sizes * drop card styling * use `btn-group-sm` for compact timezone picker * limit overall height of #righthand-panel * remove redundant CSS merge artifact
1 parent 3619d3b commit 2247a36

4 files changed

Lines changed: 9 additions & 10 deletions

File tree

ietf/static/css/ietf.scss

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,10 @@ table tbody.meta {
165165
}
166166

167167
// Style the righthand navigation panel
168+
#righthand-panel {
169+
max-height: 80vh;
170+
}
171+
168172
#righthand-nav {
169173
height: 70vh;
170174
width: inherit;
@@ -993,8 +997,3 @@ td.position-empty {
993997
#current-time {
994998
display: inline-block;
995999
}
996-
997-
// righthand nav panel styling
998-
#righthand-nav {
999-
width: inherit;
1000-
}

ietf/static/js/ietf.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ $(function () {
184184
.attr("tabindex", 0)
185185
.after($(`
186186
<div class="col-xl-2 ps-0 small">
187-
<div id="righthand-card" class="position-fixed card d-flex flex-column justify-content-start align-items-start">
188-
<nav id="righthand-nav" class="card-body navbar navbar-light bg-light overflow-auto"></nav>
187+
<div id="righthand-panel" class="position-fixed d-flex flex-column justify-content-between align-items-start">
188+
<nav id="righthand-nav" class="navbar navbar-light bg-light overflow-auto align-items-start flex-fill"></nav>
189189
</div></div>
190190
</div>
191191
`));
@@ -236,7 +236,7 @@ $(function () {
236236
});
237237

238238
if (haveExtraNav) {
239-
$('#righthand-card').append('<div id="righthand-extra" class="card-body"></div>');
239+
$('#righthand-panel').append('<div id="righthand-extra" class="py-3"></div>');
240240
extraNav.children().appendTo('#righthand-extra');
241241
extraNav.remove();
242242
}

ietf/templates/meeting/agenda.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<div class="px-3">
3333
Showing <span class="current-tz">{{ timezone }}</span> time
3434
</div>
35-
<div class="px-3 w-100">
35+
<div class="align-self-center">
3636
{% include 'meeting/tz-display.html' with id_suffix="-rh" meeting_timezone=timezone minimal=True only %}
3737
</div>
3838
</div>

ietf/templates/meeting/tz-display.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
{% load origin %}
1313
{% origin %}
1414
{% firstof id_suffix "" as suffix %}
15-
<div class="tz-display {% if minimal %}btn-group{% else %}input-group{% endif %} my-3">
15+
<div class="tz-display {% if minimal %}btn-group btn-group-sm my-2{% else %}input-group my-3{% endif %} flex-wrap">
1616
{% if not minimal %}<label class="input-group-text border-primary bg-white fw-bold">Time zone:</label>{% endif %}
1717
{% if meeting_timezone is not None %}
1818
<input type="radio"

0 commit comments

Comments
 (0)