Skip to content

Commit 8fc8e9a

Browse files
authored
fix: guard against reviews without reviewassignments. Fixes ietf-tools#3906. (ietf-tools#3915)
1 parent d736260 commit 8fc8e9a

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

ietf/templates/doc/document_review.html

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@
99
{% origin %}
1010
{{ top|safe }}
1111
{% include "doc/revisions_list.html" %}
12-
{% include "doc/review/request_info.html" %}
12+
{% if review_req %}
13+
{% include "doc/review/request_info.html" %}
14+
{% else %}
15+
<div class="alert alert-warning my-3">This review has no associated review request</div>
16+
{% endif %}
1317
{% if doc.rev != latest_rev %}
1418
<div class="alert alert-warning my-3">The information below is for an old version of the document.</div>
1519
{% endif %}
@@ -31,7 +35,7 @@
3135
<td class="edit"></td>
3236
<td>
3337
{% for review_assignment in other_reviews %}
34-
{% include "doc/review_assignment_summary.html" with current_doc_name=review_assignemnt.review_request.doc.name current_rev=review_assignment.reviewed_rev %}
38+
{% include "doc/review_assignment_summary.html" with current_doc_name=review_assignment.review_request.doc.name current_rev=review_assignment.reviewed_rev %}
3539
{% endfor %}
3640
</td>
3741
</tr>
@@ -47,4 +51,4 @@
4751
</div>
4852
</div>
4953
{% endif %}
50-
{% endblock %}
54+
{% endblock %}

0 commit comments

Comments
 (0)