Skip to content

Commit 3a1d8b3

Browse files
authored
Fix: corrects the IESG evaluation record summary for approved docs (ietf-tools#4261)
* fix: corrects the IESG evaluation record summary statement for documents where the IESG state is approved (announced or not). * fix: corrects IESG evaluation record summary for approved docs This is a correction to a previous fix that didn't pass all the tests for some documents * fix: corrects IESG evaluation record summary for approved docs Corrects the previous fix by removing commented out code. Sigh. At least these are free.
1 parent f58033e commit 3a1d8b3

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

ietf/doc/views_doc.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,6 +1216,8 @@ def document_ballot_content(request, doc, ballot_id, editable=True):
12161216
else:
12171217
position_groups.append(g)
12181218

1219+
iesg = doc.get_state("draft-iesg")
1220+
iesg_state = iesg.slug if iesg else None
12191221
if (ballot.ballot_type.slug == "irsg-approve"):
12201222
summary = irsg_needed_ballot_positions(doc, [p for p in positions if not p.is_old_pos])
12211223
else:
@@ -1241,6 +1243,7 @@ def document_ballot_content(request, doc, ballot_id, editable=True):
12411243
deferred=deferred,
12421244
summary=summary,
12431245
all_ballots=all_ballots,
1246+
iesg_state=iesg_state,
12441247
),
12451248
request=request)
12461249

ietf/templates/doc/document_ballot_content.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
</p>
4040
{% endif %}
4141
{% endif %}
42-
{% if not ballot_open %}
42+
{% if not ballot_open or iesg_state == "ann" or iesg_state == "approved" %}
4343
<p class="alert alert-warning my-3">
4444
<b>Note:</b> This ballot was opened for revision {{ ballot.rev }} and is now closed.
4545
</p>

0 commit comments

Comments
 (0)