Implement telnet server #27
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/warengonzaga/covid19-tracker-cli/79ww6j9gx |
warengonzaga
left a comment
warengonzaga
left a comment
There was a problem hiding this comment.
How to use your implementation?
|
Just run |
warengonzaga
requested review from
ianvizarra and
warengonzaga
and removed request for
warengonzaga
|
This is nice :) |
ianvizarra
left a comment
ianvizarra
left a comment
There was a problem hiding this comment.
updated attribute is available in Country API now
telnet.js
Outdated
| // empty, country, history, chartType | ||
| const [_x, country, history, chartType] = query.split('/'), | ||
| countryData = await axios.get(`${apiBaseURL}/countries/${country}`), | ||
| all = await axios.get(`${apiBaseURL}/all`), |
There was a problem hiding this comment.
We can omit this call now since we only call this to get the "updated" attribute.
The country API has updated attribute available now.
so instead of u.updated use d.updated on line 37 same with line 45
There was a problem hiding this comment.
Hi I already removed the extra API call on country tracker. Can you please verify if this is correct. Thanks!
There was a problem hiding this comment.
@ianvizarra please verify this and close if necessary so we can move forward. Will improve this later on.
iammac360
force-pushed
the
feature/telnet
branch
from
3b395b4 to
a503378
Compare
|
@ianvizarra can we close this? It seems outdated the code base... submit PR again... |
3 participants
Request for Comments!
My initial implementation of telnet server. I implemented this because when I'm using
watchto poll the updates, it doesn't render the ascii charts properly on my terminal. Not sure you encountered this guys. It is still buggy at the moment(crash prone) and it still doesn't have any proper form validation. Also, the form UI is still plain and clunky. Maybe anyone here with experience with BlessedJS and telnet programming can make this better because I'm still in the process of tinkering and learning this technologies 😅.