include timezone with date/time #25
Conversation
This makes it clear to the end user which date we are talking about instead of making it a guessing game.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/warengonzaga/covid19-tracker-cli/gzw9ffu4a |
|
@OutdatedVersion interesting... let me take a look... |
|
@OutdatedVersion there is a problem on your suggested change... Many people is relying on this CLI I tried to curl the preview link provided by Zeit and it looks like it follows the default time on the server not the timezone of the person who curl the tracker. May be you can specify what timezone is using by the user instead of relying on the machine where it runs. |
|
That's a good point, @warengonzaga! I did change it to use the UTC time zone. Though the system is already returning a different time zone than the user (i.e. the time zone the zeit server is set to). I was not able to find any implementation in the code base that attempts to return the the data in the user's time zone. For example, I receive this even though it is 12:12pm here |
|
@OutdatedVersion oh, now I see the issue... its 1AM here PH time but it returns 5PM weird... |
|
@OutdatedVersion @ianvizarra this is the cause of time issues... asof.toLocaleString()It reads the time on the server at Zeit so that's why it sends it to all CLI users. What a mess... |
|
@OutdatedVersion can you create an issue for this before the PR? Thank you! I'm about to sleep I'll let @ianvizarra review your PR. |
|
@warengonzaga issue created as #26 🤟 |
|
@OutdatedVersion your code is looks like outdated... btw thanks for you help I'm gonna close this... kindly PR a new one with the most updated code. |
2 participants
When I first requested from the command line I was confused as to the time zone of the time in the response. This aims to solve that by making it clear what we're talking about.
In doing this, I also set UTC as the default time zone. While this is already what the production environment is returning doing this allowed consistent behavior across different development environments, etc.
Original:
New behavior:
