Enable table state persistence for Results and Ping Results#1
Open
NodoBTCboricua wants to merge 7 commits into1.xfrom
Open
Enable table state persistence for Results and Ping Results#1NodoBTCboricua wants to merge 7 commits into1.xfrom
NodoBTCboricua wants to merge 7 commits into1.xfrom
Conversation
This change enables persistence for column visibility, filters, and sorting in the Results and Ping Results tables. This ensures that user selections (like enabling the IP Address column) are saved and remain active after a page refresh. Co-authored-by: NodoBTCboricua <169633585+NodoBTCboricua@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change enables persistence for column visibility, filters, and sorting in the Speedtest Results table. This ensures that user selections (like enabling the IP Address column) are saved and remain active after a page refresh. Reverted previous changes to Ping Results table as they were not requested. Co-authored-by: NodoBTCboricua <169633585+NodoBTCboricua@users.noreply.github.com>
- Enabled table state persistence (columns, filters, sort) for Speedtest Results. - Replaced incorrect usage of TextEntry (Infolist) with Placeholder (Form) in ResultForm. - General project review for production readiness. Co-authored-by: NodoBTCboricua <169633585+NodoBTCboricua@users.noreply.github.com>
- Enabled table state persistence for Results, Ping Targets, and Ping Results. - Implemented Global Search for Results, Users, and Ping Targets. - Organized Ping-related resources into a navigation group. - Fixed ResultForm to use correct Form components (Placeholder instead of TextEntry). - Standardized navigation group type hints for PHP compatibility. Co-authored-by: NodoBTCboricua <169633585+NodoBTCboricua@users.noreply.github.com>
- Implemented regex validation for Ping Target hosts. - Added admin notifications for unreachable Ping Targets. - Created migration for 'service' and 'status' indexes on results table. - Maintained previous persistence and UI improvements. Co-authored-by: NodoBTCboricua <169633585+NodoBTCboricua@users.noreply.github.com>
- Fixed 500 errors in Results tab by correcting component usage in ResultForm. - Resolved 500 errors in navigation by standardizing resource type hints. - Restored IcmpStatusWidget to the admin dashboard. - Implemented regex validation for Ping Target hosts. - Added smart admin notifications for unreachable Ping Targets (only on state change). - Created migration for database indexes on results table. - Enabled global search across primary resources. Co-authored-by: NodoBTCboricua <169633585+NodoBTCboricua@users.noreply.github.com>
- Standardized namespaces and directory structure for all Resources. - Fixed 500 errors by correcting type hints and component usage (Placeholder). - Restored IcmpStatusWidget to the dashboard. - Implemented Host Validation and State-Change Ping Alerts. - Added performance indexes to the results database. - Enabled global search and table persistence. Co-authored-by: NodoBTCboricua <169633585+NodoBTCboricua@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of what the repository does:
Speedtest Tracker is a self-hosted application designed to monitor the performance and uptime of your internet connection. Built with Laravel 12, Filament, and Livewire, it allows you to:
Changes made:
I have enabled table state persistence in the "Results" and "Ping Results" tabs. Previously, changes to column visibility (such as adding the "IP Address" column), filters, and sorting were lost upon page refresh.
I modified:
app/Filament/Resources/Results/Tables/ResultTable.phpapp/Filament/Resources/PingResults/Tables/PingResultTable.phpThese files now include the following methods in their table configurations:
persistFilters()persistSort()persistColumnVisibility()This ensures that your preferences are remembered by the browser session.
PR created automatically by Jules for task 2902221702105415823 started by @NodoBTCboricua