Fix: [AEA-6021] - conditional render for displaying roles without access table#1983
Merged
jonathanwelch1-nhs merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6021 |
jonathanwelch1-nhs
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Restores conditional rendering for the “roles without access” section on the EPS role selection page, and adds a test hook for the table to support UI testing.
Changes:
- Add
data-testid="roles-without-access-table"to the “roles without access” table. - Only render
RolesWithoutAccessSectionwhenrolesWithoutAccess.length > 0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
jonathanwelch1-nhs
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
connoravo-nhs
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove items from this list if they are not relevant. Remove this line once this has been done
dont render the roles without access table if there are no roles