Chore: [AEA-0000] - new script to create jwks and new prod jwks#1946
Merged
anthony-nhs merged 2 commits intomainfrom Mar 24, 2026
Merged
Chore: [AEA-0000] - new script to create jwks and new prod jwks#1946anthony-nhs merged 2 commits intomainfrom
anthony-nhs merged 2 commits intomainfrom
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds tooling and configuration updates related to JWKS key management, and simplifies GitHub secret setup by removing an unused CDK image-pull role secret.
Changes:
- Remove
CDK_PULL_IMAGE_ROLEexport lookup + secret-setting fromscripts/set_secrets.sh. - Add
scripts/create_new_jwks.shto generate an RSA keypair and append a new JWK into an environment-specificjwks.json. - Append a new RSA JWK entry to the production JWKS file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scripts/set_secrets.sh | Removes CDK_PULL_IMAGE_ROLE handling from secret-setting automation. |
| scripts/create_new_jwks.sh | New script to generate RSA keys and update the JWKS JSON via jq. |
| packages/staticContent/jwks/prod/jwks.json | Adds a new production JWK entry (new kid/modulus). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
jonathanwelch1-nhs
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details