Fix: [AEA-6243] - Add additional isSigningOut condition to loading page on select your role#1751
Merged
connoravo-nhs merged 21 commits intomainfrom Feb 9, 2026
Merged
Conversation
… sign out to avoid redirections Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
…Auth state & redirection race condition Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6243 |
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
connoravo-nhs
commented
Feb 6, 2026
| * } | ||
| * mockUseAuth.mockReturnValue(authState) | ||
| */ | ||
| export const mockAuthState = { |
Contributor
Author
There was a problem hiding this comment.
A shared mock for AuthState that can be re-utilised and hydrated with the values any test needs. Rather than re-mocking in each test going forward.
Contributor
There was a problem hiding this comment.
just out of curiosity is there a tech debt ticket to refactor existing tests to use this?
connoravo-nhs
changed the title
Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com>
|
bencegadanyi1-nhs
approved these changes
Feb 9, 2026
| * } | ||
| * mockUseAuth.mockReturnValue(authState) | ||
| */ | ||
| export const mockAuthState = { |
Contributor
There was a problem hiding this comment.
just out of curiosity is there a tech debt ticket to refactor existing tests to use this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Add additional isSigningOut condition to loading page on select your role.
It will now show for the redirecting "current" condition, where a user has just logged in & the new condition, if a user clicks sign out, the isSigningOut state is set and respected.
This aims to prevent the 'no roles with access' screen from being shown temporarily, as a user logs out.