This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Conversation
mcmire
force-pushed
the
remove-subscribe-block-tracker
branch
2 times, most recently
from
3d60851 to
64467d0
Compare
We do not presently use this class in any repo under the MetaMask organization. In general we have found a polling-based approach to be more reliable than a subscription-based approach.
mcmire
force-pushed
the
remove-subscribe-block-tracker
branch
from
64467d0 to
afcff8c
Compare
mikesposito
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not presently use this class in any repo under the MetaMask organization. In general we have found a polling-based approach to be more reliable than a subscription-based approach.