Structural pattern #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion and TimelinedLocation are placed under the root class Locations
…t for aggregation implemented.
…adability and easy manipulation
…readability and easy manipulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes use of the facade structural design pattern within services/location/jhu.py. Here this design pattern as simple as it may be adds simplicity to the reader and user. Here a new folder names jhu_facade was created to call the classes within jhu. This was done so that developers may have a class which simply provides the class and function provide by those classes rather than having to deal with the complexity of these classes and function implementations. Which is exactly what the facade pattern provides.
Moving forward these classes can be used and understood without have to go throught the task of reviewing the complex implementation.