DMARC not consistently denoted by failures (canada-ca#2374)

* DMARC not consistently denoted by failures

Most locations marked what control failed,
But the DMARC graphs marked which control passed

All locations now go by the failure to be consistent.

* update po files

* fix calls to api

* Run npm run extract

Co-authored-by: FestiveKyle <kyle.j.s.sullivan@gmail.com>

Author: EveningStarlight

frontend/src/DmarcReportPage.js

@@ -226,13 +226,13 @@ export default function DmarcReportPage({ summaryListResponsiveWidth }) {
       moderate: [
         {
           name: 'passSpfOnly',
-          displayName: t`Pass Only SPF`,
+          displayName: t`Fail DKIM`,
         },
       ],
       moderateAlt: [
         {
           name: 'passDkimOnly',
-          displayName: t`Pass Only DKIM`,
+          displayName: t`Fail SPF`,
         },
       ],
       weak: [

frontend/src/__tests__/DmarcReportPage.test.js

@@ -179,7 +179,7 @@ describe('<DmarcReportPage />', () => {
         </ThemeProvider>
       </UserStateProvider>,
     )
-    await waitFor(() => getAllByText(/^Pass Only SPF$/i))
+    await waitFor(() => getAllByText(/^Fail DKIM$/i))
   })
 
   it('renders tables', async () => {

frontend/src/__tests__/DmarcReportSummaryGraph.test.js

@@ -25,6 +25,6 @@ describe('<DmarcReportTimeGraph />', () => {
         </I18nProvider>
       </ThemeProvider>,
     )
-    await waitFor(() => getByText(/Pass Only SPF/i))
+    await waitFor(() => getByText(/Fail DKIM/i))
   })
 })

frontend/src/fixtures/summaryListData.js

@@ -157,12 +157,12 @@ const strengths = {
   ],
   moderate: [
     {
-      name: 'passSpfOnly',
-      displayName: t`Pass Only SPF`,
+      name: 'failDkim',
+      displayName: t`Fail DKIM`,
     },
     {
-      name: 'passDkimOnly',
-      displayName: t`Pass Only DKIM`,
+      name: 'failSpf',
+      displayName: t`Fail SPF`,
     },
   ],
   weak: [

frontend/src/locales/en.js

@@ -192,7 +192,9 @@
       "Enter your user account's verified email address and we will send you a password reset link.",
     'Envelope From': 'Envelope From',
     Fail: 'Fail',
+    'Fail DKIM': 'Fail DKIM',
     'Fail DKIM %': 'Fail DKIM %',
+    'Fail SPF': 'Fail SPF',
     'Fail SPF %': 'Fail SPF %',
     February: 'February',
     'Follow implementation guide': 'Follow implementation guide',
@@ -376,8 +378,6 @@
     'Page Size:': 'Page Size:',
     'Page {0} of {1}': ['Page ', ['0'], ' of ', ['1']],
     Pass: 'Pass',
-    'Pass Only DKIM': 'Pass Only DKIM',
-    'Pass Only SPF': 'Pass Only SPF',
     'Pass/Fail Ratios by Domain': 'Pass/Fail Ratios by Domain',
     Password: 'Password',
     'Password Updated': 'Password Updated',