Skip to content

Conversation

@Kilo59
Copy link
Owner

@Kilo59 Kilo59 commented Mar 21, 2021

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 21, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 5.17 ⭐ 5.17 ⭐ 0.00
Method Length 71.83 🙂 71.83 🙂 0.00
Working memory 18.30 ⛔ 18.30 ⛔ 0.00
Quality 51.91% 🙂 51.91% 🙂 0.00%
Other metrics Before After Change
Lines 424 424 0
Changed files Quality Before Quality After Quality Change
app/services/location/csbs.py 49.01% 😞 49.01% 😞 0.00%
app/services/location/jhu.py 50.96% 🙂 50.96% 🙂 0.00%
app/services/location/nyt.py 55.31% 🙂 55.31% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
app/services/location/nyt.py get_locations 8 ⭐ 256 ⛔ 28 ⛔ 31.93% 😞 Try splitting into smaller methods. Extract out complex expressions
app/services/location/csbs.py get_locations 11 🙂 206 ⛔ 22 ⛔ 33.99% 😞 Try splitting into smaller methods. Extract out complex expressions
app/services/location/jhu.py get_category 6 ⭐ 265 ⛔ 21 ⛔ 35.77% 😞 Try splitting into smaller methods. Extract out complex expressions
app/services/location/jhu.py get_locations 1 ⭐ 232 ⛔ 29 ⛔ 39.89% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@Kilo59 Kilo59 marked this pull request as ready for review March 21, 2021 23:04
@Kilo59 Kilo59 merged commit 73b549f into master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants