Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY?
I have notice in the Coronavirus-Tracker-API project, there are too many arguments passed around in app/location where both csbs and nyt would pass around similar parameters with almost identical code in the creation. Hence, I thought It would be a very good place to apply creational patterns.
My learnings have taught me to avoid use of Singleton Patterns in general and this thought led me to look at other types of patterns such as Builder, Factory, or Prototype patterns.
I wanted implement factory design pattern due to a lot of duplications in the code and why not apply pattern which can combine all the unnecessary work that is being done by each individually but create a factory class which does the creation for csbs and nyt.
HOW?
First, I implemented factory class to remove duplications in the methods in the locations. Which involved creation of file factory_location.py and replace the method call for the constructors.