-
-
Notifications
You must be signed in to change notification settings - Fork 314
Add testsuite for unit- and integration tests #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is gonna conflict with /v2/: https://github.com/ExpDev07/coronavirus-tracker-api/tree/v2 😢 |
|
No problem. I will waiting for release of v2 and adapt the testcases |
|
@gribok Really appreciate it. |
|
You should be good to make your edits now :). /v2/ is released. |
ExpDev07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to have testing for legacy endpoints? Shouldn't we rather focus on maintaining testing for the new /v2/ endpoints??
tests/test_data.py
Outdated
| from unittest import mock | ||
| import pytest | ||
|
|
||
| from app import data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data module no longer exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already obsolet. Accidentally push commits to early. :-)
|
Conflicts needed to be resolved. |
|
Fixed all merge conflicts. Check it out. :-) Some points to highlights;
Would be nice, to be added to contrib-list |
|
Looks good sir. |
|
@all-contributors please add @gribok for code and testing. |
|
I've put up a pull request to add @gribok! 🎉 |
Based on #64, I created a basic test suite with following features:
date.is_datetests/expected_output)tests/example_datafor testingapp.data.requests.getandapp.data.datetimeto enforce data fetch locally fromtests/example_dataREADME.mdfor testing and lintingpytestandpytesttoPipfiletodev-packagesPipfile.lockwith new dev-dependenciesTesting of PR:
ToDos:
/all. It is hard to test due to caching mechanism. Need to check, if it is possible to deactivate caching during testingMakefile