Add testsuite for unit- and integration tests#65
Add testsuite for unit- and integration tests#65ExpDev07 merged 6 commits intoExpDev07:masterfrom gribok:master
Conversation
|
This is gonna conflict with /v2/: https://github.com/ExpDev07/coronavirus-tracker-api/tree/v2 😢 |
|
No problem. I will waiting for release of v2 and adapt the testcases |
|
@gribok Really appreciate it. |
|
You should be good to make your edits now :). /v2/ is released. |
ExpDev07
left a comment
There was a problem hiding this comment.
Is it necessary to have testing for legacy endpoints? Shouldn't we rather focus on maintaining testing for the new /v2/ endpoints??
tests/test_data.py
Outdated
| from unittest import mock | ||
| import pytest | ||
|
|
||
| from app import data |
There was a problem hiding this comment.
The data module no longer exists.
There was a problem hiding this comment.
Already obsolet. Accidentally push commits to early. :-)
|
Conflicts needed to be resolved. |
|
Fixed all merge conflicts. Check it out. :-) Some points to highlights;
Would be nice, to be added to contrib-list |
|
Looks good sir. |
|
@all-contributors please add @gribok for code and testing. |
|
I've put up a pull request to add @gribok! 🎉 |
Based on #64, I created a basic test suite with following features:
date.is_datetests/expected_output)tests/example_datafor testingapp.data.requests.getandapp.data.datetimeto enforce data fetch locally fromtests/example_dataREADME.mdfor testing and lintingpytestandpytesttoPipfiletodev-packagesPipfile.lockwith new dev-dependenciesTesting of PR:
ToDos:
/all. It is hard to test due to caching mechanism. Need to check, if it is possible to deactivate caching during testingMakefile