Creational pattern on data source #477
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The factory and singleton patterns were introduced to the data source to make it easier to modify the code when changes need to be made to the data source and to reduce memory usage.
To do this, I first created a factory called DataSourceFactory, including getInstance and getService methods. After that, I created subclasses of the factory for each of the three data sources. Then, I make the factory a singleton by using the getInstance method, which creates a new object the first time it is called and stores it in a static variable. The method returns the instance each time it is called after that. In addition, I made the Service a singleton by using getService, which is implemented in the same way as getInstance.