Add LocationCachingProxy to add caching to location requests#468
Closed
hughie-coles wants to merge 1 commit intoExpDev07:masterfrom
Closed
Add LocationCachingProxy to add caching to location requests#468hughie-coles wants to merge 1 commit intoExpDev07:masterfrom
hughie-coles wants to merge 1 commit intoExpDev07:masterfrom
Conversation
Collaborator
|
Thanks for the PR. It may take me a bit to work through the PR but I'll try to do it soon. |
Author
|
Honestly, I'm just doing these PRs as part of a class project, so no need to spend any effort on them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I am applying the proxy pattern to add caching to our location API calls. This will improve performance. The caching period is also configurable