Bridge Pattern for DataSources Implemented #427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Was Done
Hello, today I implemented the a structural design pattern known as the Bridge Pattern.
I have implemented the bridge pattern in the DATA_SOURCES dictionary. The reason I have done this is because this allows a decoupling between the data source that is provided and the way that the specific implementation of the data source handles returning data.
Specifically speaking, rather than having DATA_SOURCE store a reference of each available data source and then calling a generic method get_all which is implemented in each of those data source objects (NYT, CSBS, JHU) that then superficially just call get_locations; get_locations() is called indirectly by having a 'bridge' method call get_all which then calls get_locations of each data source object.