Aggregation #1 #422
Closed
Aggregation #1 #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codes were repeated so the first aggregation i did was create a seperate function for it. in the file path ...\app\routers\v2.py and i added a new function get_latest_Data and thus i changed the code for return in function to "get_latest"and finally changed for return in function to "get_locations"
Collaborator
|
This could be worthwhile. On my phone now so I can't see it context very well but I will look again. |
Kilo59
requested changes
Jul 27, 2021
Collaborator
Kilo59
left a comment
Kilo59
left a comment
There was a problem hiding this comment.
I think I would approve with these minimal changes.
| NYT = "nyt" | ||
|
|
||
|
|
||
| def get_latest_data(locations): |
Collaborator
There was a problem hiding this comment.
Suggested change
| def get_latest_data(locations): | |
| def _get_latest_data(locations) -> dict: |
Can we make this private since it really shouldn't be used outside of this module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codes were repeated so the first aggregation i did was create a seperate function for it. in the file path ...\app\routers\v2.py and i added a new function get_latest_Data and thus i changed the code for return in function to "get_latest"and finally changed for return in function to "get_locations"