Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions app/location/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,21 +72,23 @@ def serialize(self):
"recovered": self.recovered,
},
}
class LocationInfo:
def __init__(self, country, province, coordinates):
self.country = country,
self.province = province,
self.coordinates = coordinates,


class TimelinedLocation(Location):
class TimelinedLocationObjectObject(Location):
"""
A location with timelines.
"""

# pylint: disable=too-many-arguments
def __init__(self, id, country, province, coordinates, last_updated, timelines):
def __init__(self, id, location, last_updated, timelines):
super().__init__(
# General info.
id,
country,
province,
coordinates,
location,
last_updated,
# Statistics (retrieve latest from timelines).
confirmed=timelines.get("confirmed").latest or 0,
Expand Down
6 changes: 3 additions & 3 deletions app/location/nyt.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
"""app.locations.nyt.py"""
from . import TimelinedLocation
from . import TimelinedLocationObject


class NYTLocation(TimelinedLocation):
class NYTLocation(TimelinedLocationObject):
"""
A NYT (county) Timelinedlocation.
A NYT (county) TimelinedLocationObject.
"""

# pylint: disable=too-many-arguments,redefined-builtin
Expand Down
4 changes: 2 additions & 2 deletions app/services/location/jhu.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

from ...caches import check_cache, load_cache
from ...coordinates import Coordinates
from ...location import TimelinedLocation
from ...location import TimelinedLocationObject
from ...models import Timeline
from ...utils import countries
from ...utils import date as date_util
Expand Down Expand Up @@ -172,7 +172,7 @@ async def get_locations():

# Create location (supporting timelines) and append.
locations.append(
TimelinedLocation(
TimelinedLocationObject(
# General info.
index,
location["country"],
Expand Down
11 changes: 7 additions & 4 deletions tests/test_location.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,16 @@ def test_location_class(

# Date now.
now = datetime.utcnow().isoformat() + "Z"

# Location.
location_obj = location.TimelinedLocation(
test_id,
location_obj = location.LocationInfo(
country,
province,
coords,
coords
)
location_obj = location.TimelinedLocationObject(
test_id,
location,
now,
{"confirmed": confirmed, "deaths": deaths, "recovered": recovered,},
)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_nyt.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import pytest

from app.location import TimelinedLocation
from app.location import TimelinedLocationObject
from app.location.nyt import NYTLocation
from app.services.location import nyt
from tests.conftest import mocked_strptime_isoformat
Expand All @@ -23,7 +23,7 @@ async def test_get_locations(mock_client_session):
serialized_locations = []
for location in locations:
assert isinstance(location, NYTLocation)
assert isinstance(location, TimelinedLocation)
assert isinstance(location, TimelinedLocationObject)

# Making sure country population is a non-zero value
assert location.country_population != 0
Expand Down