Skip to content

Conversation

@hughie-coles
Copy link

This PR represents the following work:

Add a V3 router for my changes
Add a new Source model that represents the aggregate root of my data
Added the V3 sources and sources/{name} endpoints to retrieve the aggregate data.

The main purpose of this PR is to refactor the application to use the aggregate pattern. The intention is to simplify data access and storage by minimizing the number of entities that are directly accessed.

@Kilo59
Copy link
Collaborator

Kilo59 commented Jul 27, 2021

If you are serious about contributing to the project I suggest reading up on FastAPI.
Your endpoints don't take advantage of its features, it's written as if it were a Flask endpoint.

https://fastapi.tiangolo.com/tutorial/query-params/
https://fastapi.tiangolo.com/tutorial/dependencies/

@Kilo59 Kilo59 closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants