Skip to content

Conversation

@atayyabi
Copy link

Two main changes implemented here are:

  1. Move the implementation of get_all() and get(...) to the parent class and add a new abstract method to the parent class called get_location(). then we moved the get_location() method inside the child class in each module containing the child classes
  2. changed the data.init.py module to load the DATA_SOURCES through a new method called getDataSources in services.location.init.py (so that each implementation details of the child sub classes are not leaked outside the module)

@Kilo59 Kilo59 closed this Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants