AggreagateOne #374
Closed
AggreagateOne #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExpDev07
requested changes
Jul 24, 2021
Owner
ExpDev07
left a comment
ExpDev07
left a comment
There was a problem hiding this comment.
Mulitple errors in the code that would break the program. Also, what is this assignment 8? Why are there 10+ PRs. Is this a student assignment?
Author
|
Yes, it is an assignment i must do, it's fine if you reject the pull request it is just something i must do.
Sent from Outlook<http://aka.ms/weboutlook>
…________________________________
From: Marius ***@***.***>
Sent: July 24, 2021 3:00 PM
To: ExpDev07/coronavirus-tracker-api ***@***.***>
Cc: codestarAI ***@***.***>; Author ***@***.***>
Subject: Re: [ExpDev07/coronavirus-tracker-api] AggreagateOne (#374)
@ExpDev07 requested changes on this pull request.
Mulitple errors in the code that would break the program. Also, what is this assignment 8? Why are there 10+ PRs. Is this a student assignment?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#374 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKWUTCN6YGHWDGSUGV2HML3TZLIQPANCNFSM5A5RE7EQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##What?
this is a modified version of the models file. the TimeLine methods implemented in a different way
##why?
this is to see if the modified code is an more efficient code.