added an second aggregate pattern to simplify code design #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilo59
requested changes
Jul 24, 2021
Collaborator
Kilo59
left a comment
Kilo59
left a comment
There was a problem hiding this comment.
These are only additions. If this is a simplification you should be removing the code this is meant to simplify.
Also, there are various pep8 violations and other such errors that the linter should warn about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part/second aggregate for Assignment 8. I created one file called utils.py which hosts the functions that are needed/could be used with reference to utilities. Since a utility includes http requests, and date the aggregate helps to simplify the design and usage of the utilities while reusing code.