Skip to content

Refactor Timeline class to pydantic model #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tanwinn wants to merge 13 commits into from
Closed

Refactor Timeline class to pydantic model #317

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6e5bf9f
reduce cache size (#21)
Kilo59 May 2, 2020
da822ba
Update Procfile
Kilo59 May 2, 2020
b085652
Update Procfile
Kilo59 May 3, 2020
a1dcfb4
Update jhu.py
Kilo59 May 3, 2020
cc768a9
update max requests and max jitters
Kilo59 May 4, 2020
ba056ce
Add .deepsource.toml
deepsourcebot May 7, 2020
e54724e
Update Procfile
Kilo59 May 8, 2020
170eb12
Cache mem optimize (#23)
Kilo59 May 9, 2020
7fe38b9
Sentry (#24)
Kilo59 May 9, 2020
96efc92
use official middleware (#25)
Kilo59 May 9, 2020
ecb0a68
cache redis json serialization error
Kilo59 May 9, 2020
464453d
fix nyt redis serialization error
Kilo59 May 9, 2020
05001f9
refactor Timeline class to pydantic model
tanwinn May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Sentry (#24) 
* add sentry-asgi

* sentry middleware
  • Loading branch information
@Kilo59
Kilo59 authored May 9, 2020
commit 7fe38b9b7304b25d7edee2a7d923d1b25db0c60d
1 change: 1 addition & 0 deletions Pipfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ pydantic = {extras = ["dotenv"],version = "*"}
python-dateutil = "*"
requests = "*"
scout-apm = "*"
sentry-asgi = "*"
uvicorn = "*"

[requires]
Expand Down
103 changes: 58 additions & 45 deletions Pipfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions app/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ class _Settings(BaseSettings):
local_redis_url: AnyUrl = None
# Scout APM
scout_name: str = None
# Sentry
sentry_dsn: str = None


@functools.lru_cache()
Expand Down
10 changes: 10 additions & 0 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import logging

import pydantic
import sentry_asgi
import sentry_sdk
import uvicorn
from fastapi import FastAPI, Request, Response
from fastapi.middleware.cors import CORSMiddleware
Expand All @@ -23,6 +25,9 @@

SETTINGS = get_settings()

if SETTINGS.sentry_dsn: # pragma: no cover
sentry_sdk.init(dsn=SETTINGS.sentry_dsn)

APP = FastAPI(
title="Coronavirus Tracker",
description=(
Expand All @@ -47,6 +52,11 @@
else:
LOGGER.debug("No SCOUT_NAME config")

# Sentry Error Tracking
if SETTINGS.sentry_dsn: # pragma: no cover
LOGGER.info("Adding Sentry middleware")
APP.add_middleware(sentry_asgi.SentryMiddleware)

# Enable CORS.
APP.add_middleware(
CORSMiddleware,
Expand Down
16 changes: 8 additions & 8 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-i https://pypi.org/simple
appdirs==1.4.3
astroid==2.4.0
astroid==2.4.1
async-asgi-testclient==1.4.4
async-generator==1.10
asyncmock==0.4.2
Expand All @@ -13,8 +13,8 @@ click==7.1.2
coverage==5.1
coveralls==2.0.0
docopt==0.6.2
gitdb==4.0.4
gitpython==3.1.1
gitdb==4.0.5
gitpython==3.1.2
idna==2.9
importlib-metadata==1.6.0 ; python_version < '3.8'
invoke==1.4.1
Expand All @@ -29,17 +29,17 @@ pathspec==0.8.0
pbr==5.4.5
pluggy==0.13.1
py==1.8.1
pylint==2.5.0
pylint==2.5.2
pyparsing==2.4.7
pytest-asyncio==0.11.0
pytest-asyncio==0.12.0
pytest-cov==2.8.1
pytest==5.4.1
pytest==5.4.2
pyyaml==5.3.1
regex==2020.4.4
regex==2020.5.7
requests==2.23.0
responses==0.10.14
six==1.14.0
smmap==3.0.2
smmap==3.0.4
stevedore==1.32.0
toml==0.10.0
typed-ast==1.4.1
Expand Down
2 changes: 2 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ python-dateutil==2.8.1
python-dotenv==0.13.0
requests==2.23.0
scout-apm==2.14.1
sentry-asgi==0.2.0
sentry-sdk==0.14.3
six==1.14.0
starlette==0.13.2
urllib3[secure]==1.25.9 ; python_version >= '3.5'
Expand Down