👍 fixs recovery data in api/v2 jhu

[codedawi]

• reimplements the get_category("recovered") methods in jhu service.
• adds/fixes the tests for recovered data now.
• resolves the merge issue related to missing recovery data from select countries.
  • Sierra Leone
  • Netherlands, Bonaire, Sint Eustatius and Saba
  • Malawi
  • France, Saint Pierre and Miquelon
  • United Kingdom, Falkland Islands (Malvinas)
  • South Sudan
  • Western Sahara
  • Sao Tome and Principe
  • Yemen
  • Comoros
  • Tajikistan
  • Lesotho

While reviewing the jhu service code I uncovered at critical bug that could expose this service to data & uptime issues in the future. In the PR the function parse_history is implemented as a temporary fix which will prevent the service from going down and providing consumers inaccurate data.

Add note to code:

# ***************************************************************************
# TODO: This iteration approach assumes the indexes remain the same
#       and opens us to a CRITICAL ERROR. The removal of a column in the data source
#       would break the API or SHIFT all the data confirmed, deaths, recovery producting
#       incorrect data to consumers.
# ***************************************************************************

Potential address in @Kilo59's refactor mentioned.

FIXES: #161 #276 #113

FIXES: codedawi/covid19-badges#1

[Kilo59]

@codedawi Hey thanks for this! 😄 I'll take a look at this ASAP.

[Kilo59]

@codedawi It definitely appears to have fixed the recoveries of many locations (US, AU, etc), but many other locations that are not showing up in the logs as having a "merge error" (DE, CN, CA etc) still show zero recoveries (for me locally).

I'm almost inclined to merge it anyways 😄 .
However certain locations such as the UK are showing partial recovery numbers instead, which IMO is worse than still showing 0.

Any API users please feel free to chime in.

{
  "latest": {
    "confirmed": 250138,
    "deaths": 35422,
    "recovered": 1067
  },
  "locations": [
    {
      "id": 217,
      "country": "United Kingdom",
      "country_code": "GB",
      "country_population": 66488991,
      "province": "Bermuda",
      "last_updated": "2020-05-20T20:52:14.791765Z",
      "coordinates": {
        "latitude": "32.3078",
        "longitude": "-64.7505"
      },
      "latest": {
        "confirmed": 125,
        "deaths": 9,
        "recovered": 78
      }
    },
...
    {
      "id": 223,
      "country": "United Kingdom",
      "country_code": "GB",
      "country_population": 66488991,
      "province": "",
      "last_updated": "2020-05-20T20:52:14.806740Z",
      "coordinates": {
        "latitude": "55.3781",
        "longitude": "-3.436"
      },
      "latest": {
        "confirmed": 248818,
        "deaths": 35341,
        "recovered": 0
      }
    },
...
    {
      "id": 257,
      "country": "United Kingdom",
      "country_code": "GB",
      "country_population": 66488991,
      "province": "Falkland Islands (Malvinas)",
      "last_updated": "2020-05-20T20:52:14.884740Z",
      "coordinates": {
        "latitude": "-51.7963",
        "longitude": "-59.5236"
      },
      "latest": {
        "confirmed": 13,
        "deaths": 0,
        "recovered": 0
      }
    }
  ]
}

I think I would like to merge this immediately to the US hosted version of the API that's based off my own fork.

[codedawi]

Any update on getting this merged in? If not we can just close.