Skip to content

Conversation

@Kilo59
Copy link
Collaborator

@Kilo59 Kilo59 commented May 2, 2020

I believe the cache sizes can be much lower still.
AFIAK the maxsize isn't the "size" of the cache so much as it is the number of recent calls to the function to save. get_category() only has 3 possible parameters it receives. So my understanding is as long as the max size is greater than those 3 different function calls everything should work fine.

As per the standard lib lru cache which I believe cachetools is based on.

https://docs.python.org/3/library/functools.html#functools.lru_cache

Decorator to wrap a function with a memoizing callable that saves up to the maxsize most recent calls.

Future steps

  • investigate and further optimize the cache settings to reduce memory usage

@Kilo59 Kilo59 added performance Issue related to performance and optimizations down Related to API availability labels May 2, 2020
@Kilo59 Kilo59 merged commit 37a1ad0 into ExpDev07:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

down Related to API availability performance Issue related to performance and optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant