reduce TTL cache maxsize #308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the cache sizes can be much lower still.
AFIAK the
maxsizeisn't the "size" of the cache so much as it is the number of recent calls to the function to save.get_category()only has 3 possible parameters it receives. So my understanding is as long as the max size is greater than those 3 different function calls everything should work fine.As per the standard lib
lrucache which I believecachetoolsis based on.https://docs.python.org/3/library/functools.html#functools.lru_cache
Future steps