Skip to content

Conversation

@Kilo59
Copy link
Collaborator

@Kilo59 Kilo59 commented Apr 11, 2020

Our current dockerfile was using the tiangolo/uvicorn-gunicorn-fastapi
docker image, but was configured to run as uvicorn directly.

  • Updated Dockerfile and docker-compose to work with gunicorn (running uvicorn workers).
  • Publish the correct port (80)
  • Added invoke docker --build to easily build a docker image.
  • Added invoke docker --run to start the container and "publish" the correct port

fixes #269

After building and running the container, the API should be reachable locally at
http://192.168.99.100/

image

Next steps

Kilo59 added 2 commits April 10, 2020 21:28
* Use gunicorn

* add docker build + run invoke tasks
@Kilo59 Kilo59 added dev Issue related to ease of development and code smells docker Docker related issue labels Apr 11, 2020
@Kilo59 Kilo59 requested a review from ExpDev07 April 11, 2020 01:52
@Kilo59 Kilo59 self-assigned this Apr 11, 2020
@Kilo59 Kilo59 changed the title [WIP] Docker updates Docker updates Apr 11, 2020
@Kilo59 Kilo59 marked this pull request as ready for review April 11, 2020 01:59
@Kilo59 Kilo59 changed the title Docker updates Fix Docker ports & Gunicorn Apr 11, 2020
@Kilo59 Kilo59 merged commit 17eacea into ExpDev07:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Issue related to ease of development and code smells docker Docker related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerfile cannot be run as is.

1 participant