Skip to content

Source NYT #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kilo59 merged 13 commits into from
Apr 13, 2020
Merged

Source NYT #259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8751f7e
Merge pull request #1 from ExpDev07/master
ibhuiyan17 Apr 3, 2020
e8cd213
Started adding documentation for NYT source
ibhuiyan17 Apr 3, 2020
9ffe9e6
Started nyt.py file in services.location module
ibhuiyan17 Apr 7, 2020
4903abb
Testing nischal pushing to branch
nischalshankar Apr 8, 2020
6a744a6
Merge pull request #2 from ibhuiyan17/source-nyt
ibhuiyan17 Apr 8, 2020
a9c5f37
Merge remote-tracking branch 'upstream/master'
nischalshankar Apr 8, 2020
736b90d
Merge branch 'master' of https://github.com/ibhuiyan17/coronavirus-tr…
nischalshankar Apr 8, 2020
ce841d3
Temp directory to test parsing nyt timeseries
ibhuiyan17 Apr 10, 2020
5f587a9
Locally working nyt source on v2
nischalshankar Apr 10, 2020
cf9694c
Deleted temporary folder so it hopefully passes build
ibhuiyan17 Apr 10, 2020
8a27080
Added mock data, unit tests, and regression tests for source NYT
ibhuiyan17 Apr 12, 2020
59437b3
Updated README to reflect new NYT source
nischalshankar Apr 12, 2020
149de08
Fixed requested points from PR
ibhuiyan17 Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed requested points from PR
  • Loading branch information
@ibhuiyan17
ibhuiyan17 committed Apr 13, 2020
commit 149de08d48172aa1610f05f1d1ce2e45da615e9c
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Support multiple data-sources.

## New York Times is now available as a source!

**Specify source parameter with ?source=nyt. NYT also provides a timeseries! To view timelines of cases by US counties use ?source=nyt&timelines=1**
**Specify source parameter with ?source=nyt. NYT also provides a timeseries! To view timelines of cases by US counties use ?source=nyt&timelines=true**

## Recovered cases showing 0

Expand Down
1 change: 0 additions & 1 deletion app/data/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

# Mapping of services to data-sources.
DATA_SOURCES = {"jhu": JhuLocationService(), "csbs": CSBSLocationService(), "nyt": NYTLocationService()}
# DATA_SOURCES = {"jhu": JhuLocationService(), "csbs": CSBSLocationService()}


def data_source(source):
Expand Down
5 changes: 1 addition & 4 deletions app/services/location/nyt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ async def get_locations():
# The normalized locations.
locations = []

idx = 0
for county_state, histories in grouped_locations.items():
for idx, (county_state, histories) in enumerate(grouped_locations.items()):
# Make location history for confirmed and deaths from dates.
# List is tuples of (date, amount) in order of increasing dates.
confirmed_list = histories["confirmed"]
Expand Down Expand Up @@ -121,6 +120,4 @@ async def get_locations():
)
)

idx += 1

return locations