-
-
Notifications
You must be signed in to change notification settings - Fork 314
#232: Make all endpoints async #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8b55c16
Setup a global aiohttp.ClientSession instance
james-gray 63f6884
Make core blocking functions async using aiohttp
james-gray 9b94573
Add async/await keywords as necessary up the call chain
james-gray 2f40cea
Use asyncache to cache results of asyncio coroutines
james-gray 63675dc
Add test dependencies
james-gray 0e11daa
Update test_jhu to handle asyncio
james-gray 3bfc94e
Update test_csbs to handle asyncio
james-gray c4a6c9e
Update test_routes to handle asyncio
james-gray 5b798c5
Remove unused imports
james-gray 711ad5f
Ignore intelliJ meta folder
james-gray 0e827fb
Add an async_api_client pytest fixture
james-gray afca2a9
Consolidate fixtures into conftest.py
james-gray 3dfe15f
Make mock_client_session a proper Pytest fixture
james-gray 990c82c
Use mocked_session_get by default
james-gray 6f231ce
Add test for ClientSession setup/teardown
james-gray b25fe73
Update Pipfile.lock
james-gray 77100b0
Fix linter warnings
james-gray f9b0ce1
Black formatting
james-gray 99ea07e
Fallback to pypi-provided backports for async test utils
james-gray 71e2190
Avoid mock.patch decorators
james-gray 90394da
Run formatter
james-gray 4d9b848
Add missing dependency
james-gray c188058
add markers to backports
Kilo59 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,4 +66,7 @@ docs/_build/ | |
| target/ | ||
|
|
||
| # OSX Stuff | ||
| .DS_Store | ||
| .DS_Store | ||
|
|
||
| # IntelliJ/Pycharm | ||
| .idea/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These back-ports should be adjusted so that they are only installed when required.
https://pipenv.readthedocs.io/en/latest/basics/#specifying-versions-of-a-package
https://pipenv.readthedocs.io/en/latest/advanced/#specifying-basically-anything
I'll try to do this tonight if I have a chance.
Thanks for all the notes, should make this easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, happy to help!