Skip to content

#232: Make all endpoints async #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgr-ableton wants to merge 16 commits into from
Closed

#232: Make all endpoints async #255

jgr-ableton wants to merge 16 commits into from

Conversation

@jgr-ableton
Copy link

@jgr-ableton jgr-ableton commented Apr 2, 2020

This branch adds asyncio support to all API endpoints to make them non-blocking, using asyncio and aiohttp.

  • Used aiohttp to make the two requests for data sources instead of requests, as requests is not compatible with asyncio. A key piece of this is the addition of a global aiohttp.ClientSession instance, which exists for the entire application run.
  • Updated methods up the call chain with async/await as necessary.
  • Updated the endpoint methods to be async as per https://fastapi.tiangolo.com/async/.
  • Updated the tests to handle asynchronous calls.
  • Added tests for the setup and teardown of the global ClientSession.

Added dependencies:

  • aiohttp
  • asyncache
  • async-asgi-testclient
  • pytest-asyncio

#232

james-gray added 16 commits April 2, 2020 13:19
@james-gray
Setup a global aiohttp.ClientSession instance
8b55c16
@james-gray
Make core blocking functions async using aiohttp
63f6884
@james-gray
Add async/await keywords as necessary up the call chain
9b94573
@james-gray
Use asyncache to cache results of asyncio coroutines
2f40cea 
See: https://github.com/hephex/asyncache
@james-gray
Add test dependencies
63675dc 
These are required to be able to test asyncio functionality, as well as making ASGI test clients play nice asynchronously.
@james-gray
Update test_jhu to handle asyncio
0e11daa 
- Move test fixtures into tests/fixtures.py
- Update test fixtures to mock aiohttp.ClientSession.get, instead of requests.get
- Add a context manager to replace the global httputils.client_session with an AsyncMock
- Misc. cleanup
@james-gray
Update test_csbs to handle asyncio
3bfc94e
@james-gray
Update test_routes to handle asyncio
c4a6c9e
@james-gray
Remove unused imports
5b798c5
@james-gray
Ignore intelliJ meta folder
711ad5f
@james-gray
Add an async_api_client pytest fixture
0e827fb
@james-gray
Consolidate fixtures into conftest.py
afca2a9 
I didn't see this file when I first added the new fixtures.
@james-gray
Make mock_client_session a proper Pytest fixture
3dfe15f
@james-gray
Use mocked_session_get by default
990c82c 
One can still define a separate responder function here, but since this is the
only response defined for the tests thus far, this seems like a reasonable default.
@james-gray
Add test for ClientSession setup/teardown
6f231ce
@james-gray
Update Pipfile.lock
b25fe73
@jgr-ableton jgr-ableton closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jgr-ableton @james-gray