Skip to content

Add CONTRIBUTION guide #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gribok wants to merge 6 commits into from
Closed

Add CONTRIBUTION guide #205

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f248d1
first version of contrib-guide ExpDev07/coronavirus-tracker-api#169
gribok Mar 26, 2020
373fdc7
fix refs in contrib-guide
gribok Mar 26, 2020
ebbd19f
add more refs to contrib guide
gribok Mar 26, 2020
6daffde
Merge branch 'master' of https://github.com/ExpDev07/coronavirus-trac…
gribok Mar 29, 2020
b3ac508
Add formatting to styleguide
gribok Mar 29, 2020
d56cb32
Add test coverage measuring. See ExpDev07/coronavirus-tracker-api#207
gribok Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add formatting to styleguide
  • Loading branch information
@gribok
gribok committed Mar 29, 2020
commit b3ac50865778f7c5e2adde7715e75583c0dc791b
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Unsure where to begin contributing to coronavirus-tracker-api ? You can start by
## Styleguide

Please follow [PEP8](https://www.python.org/dev/peps/pep-0008/) guide.
See [Running Test](./README.md#running-tests) and [Linting](./README.md#linting) for further instructions.
See [Running Test](./README.md#running-tests), [Linting](./README.md#linting) and [Formatting](./README.md#formatting) sections for further instructions to validate your change.

Copy link
Collaborator

@Kilo59 Kilo59 Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a step here about running the formatter?
pipenv run fmt or make fmt or black . -l 120

Copy link
Contributor Author

@gribok gribok Mar 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for feedback. Added make ftm to styleguide section.


We encourage you to pitch in and join the [Coronavirus Tracker API Team](https://github.com/ExpDev07/coronavirus-tracker-api#contributors-)!
Expand Down