Skip to content

add recoveries to v1 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ExpDev07 merged 4 commits into from
Mar 26, 2020
Merged

add recoveries to v1 #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac998a2
add
Mar 26, 2020
8c69267
fixed
Mar 26, 2020
5b7d52b
fixedd
Mar 26, 2020
50f28ed
fix tests
Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/services/location/jhu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ def get_category(category):
# URL to request data from.
url = base_url + "time_series_covid19_%s_global.csv" % category

# Different URL is needed for recoveries.
# Read about deprecation here: https://github.com/CSSEGISandData/COVID-19/tree/master/csse_covid_19_data/csse_covid_19_time_series.
if category == "recovered":
url = base_url + "time_series_19-covid-Recovered.csv"

# Request the data
request = requests.get(url)
text = request.text
Expand Down
0 ...e_data/time_series_19-covid-Recovered.csv → .../time_series_covid19_recovered_global.csv
View file
Open in desktop
File renamed without changes.
3 changes: 0 additions & 3 deletions tests/test_jhu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ def read_file(self, state):
# Determine filepath.
filepath = "tests/example_data/{}.csv".format(state)

if state == "recovered":
filepath = "tests/example_data/time_series_19-covid-Recovered.csv"

# Return fake response.
print("Try to read {}".format(filepath))
with open(filepath, "r") as file:
Expand Down