apply black/isort formatting/sorting #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilo59
commented
Mar 25, 2020
| # Mapping of country names to alpha-2 codes according to | ||
| # https://en.wikipedia.org/wiki/ISO_3166-1. | ||
| # As a reference see also https://github.com/TakahikoKawasaki/nv-i18n (in Java) | ||
| # fmt: off |
Collaborator
Author
There was a problem hiding this comment.
I turned the formatting off here since it looks so nice 😄
Kilo59
commented
Mar 25, 2020
Comment on lines
23
to
29
| fmt: | ||
| isort -rc --atomic | ||
| black . | ||
|
|
||
| check-fmt: | ||
| isort -rc --check | ||
| black . --check --diff |
Collaborator
Author
There was a problem hiding this comment.
new fmt and check-fmt commands
disable `bad-continuation` up max-line-length to `120`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #187
Will also impact #169
blackandisortto play nice with each other and respect a line length of120.make fmtmake check-fmthttps://github.com/psf/black
https://github.com/timothycrosley/isort
TODO
120