Consider switching (from Flask) to ASGI framework

[Kilo59]

Have you considered switching to one of the newer ASGI based web frameworks?

I would like to recommend FastAPI

Among other things, I believe this project would greatly benefit from these features.

1. Automatic Swagger/OpenAPI API documentation tools (and ReDoc)
2. Handle more simultaneous request. Benchmarks
3. Ease of development

I would be happy to work on this if it's something you think the project could benefit from.

https://fastapi.tiangolo.com/alternatives/
https://fastapi.tiangolo.com/advanced/wsgi/

[ExpDev07]

Looks interesting.

[Kilo59]

[ExpDev07]

Looks nice!

[Kilo59]

For the initial switchover I'm going to attempt to keep the exact same shape of v2. As such I've created data models (for use as Response Models) based on the existing Location, TimelinedLocation, Timeline classes as well as the shape of the currently returned JSON.

https://fastapi.tiangolo.com/tutorial/response-model/#see-it-in-the-docs

class Totals(pydantic.BaseModel):
    confirmed: int
    deaths: int
    recovered: int


class Latest(pydantic.BaseModel):
    latest: Totals


class TimelineStats(pydantic.BaseModel):
    latest: int
    timeline: Dict[str, int]


class TimelinedLocation(pydantic.BaseModel):
    confirmed: TimelineStats
    deaths: TimelineStats
    recovered: TimelineStats


class Country(pydantic.BaseModel):
    coordinates: Dict
    country: str
    country_code: str
    id: int
    last_updated: dt.datetime
    latest: Totals
    province: str = ""
    timelines: TimelinedLocation

@APP.get("/latest", response_model=Latest)
def get_latest():
    ...

@APP.get("/locations", response_model=AllLocations)
def get_all_locations(country_code: str = None, timelines: int = None):
   ...

@APP.get("/locations/{id}", response_model=Location)
def get_location_by_id(id: int):
   ...

[ExpDev07]

Great job

[mustaphee]

Although I feel it might not really be needed to switch Framework, however, if you decide to use FastAPI, I would gladly assist with the switch

[ExpDev07]

@mustaphee the code really isn't that advanced yet, so a framework switch wouldn't be the biggest deal given it provides benefits, which it looks like it very much does. We can just see how it turns out, if I'm happy with it and it's compatible with the current endpoints (so not to break apps using it), I'll merge.