[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.3#20
[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.3#20Dustin4444 wants to merge 1 commit intomainfrom
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14896210
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Dustin4444, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security by upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, generated by Snyk, upgrades urllib3 from version 1.x to 2.6.3 to address a security vulnerability. While the security fix is important, this constitutes a major version upgrade for urllib3 and introduces breaking changes. My review has identified critical issues that will break your project's dependencies and test suite. Specifically, there is a dependency conflict with the selenium package, which does not support urllib3 v2.x yet. Additionally, your codebase in ietf/utils/test_runner.py uses a urllib3 API that was removed in v2.0. Due to these issues, this PR cannot be merged in its current state.
| tqdm>=4.64.0 | ||
| Unidecode>=1.3.4 | ||
| urllib3>=1.26,<2 | ||
| urllib3>=2.6.3 |
There was a problem hiding this comment.
The upgrade of urllib3 to version 2.x introduces breaking changes that will affect this project.
-
Dependency Conflict with
selenium: Theseleniumpackage, which is a dependency in this project (selenium>=4.0), requiresurllib3~=1.26. This version constraint is not compatible withurllib3v2.x. The latest versions ofseleniumstill have this requirement, so upgradingurllib3will cause a dependency conflict and break tests that rely onselenium. You can track theseleniumupgrade issue here: SeleniumHQ/selenium#12011. -
Incompatible API Usage: The file
ietf/utils/test_runner.pyuses an API fromurllib3that has been removed in version 2.0. On line 128,urllib3.Retryis called with aredirectkeyword argument:http = urllib3.PoolManager(retries=urllib3.Retry(99, redirect=False))
This argument is no longer supported in
urllib3v2.0 and will cause aTypeErrorat runtime.
Given these critical issues, this pull request cannot be merged as is. It is recommended to wait until selenium supports urllib3 v2.x before proceeding with this upgrade.
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.