Skip to content

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.3#20

Open
Dustin4444 wants to merge 1 commit intomainfrom
snyk-fix-be5b3b9d282ea7767ba807f1cafc5e01
Open

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.3#20
Dustin4444 wants to merge 1 commit intomainfrom
snyk-fix-be5b3b9d282ea7767ba807f1cafc5e01

Conversation

@Dustin4444
Copy link
Copy Markdown
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • requirements.txt
⚠️ Warning
xml2rfc 3.25.0 requires platformdirs, which is not installed.
xml2rfc 3.25.0 requires configargparse, which is not installed.
xml2rfc 3.25.0 requires google-i18n-address, which is not installed.
xml2rfc 3.25.0 requires intervaltree, which is not installed.
xml2rfc 3.25.0 requires jinja2, which is not installed.
xml2rfc 3.25.0 requires pycountry, which is not installed.
types-requests 2.31.0.20231231 requires urllib3, which is not installed.
selenium 4.11.2 requires urllib3, which is not installed.
scout-apm 2.26.1 requires urllib3, which is not installed.
requests 2.31.0 requires urllib3, which is not installed.
pydantic-settings 2.0.3 has requirement pydantic>=2.0.1, but you have pydantic 1.10.26.
celery 5.3.0 requires kombu, which is not installed.

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14896210
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
datatracker Error Error Jan 14, 2026 9:22am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 14, 2026

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch snyk-fix-be5b3b9d282ea7767ba807f1cafc5e01

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @Dustin4444, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security by upgrading the urllib3 Python package. The update addresses a known vulnerability, ensuring that the application relies on a more secure and up-to-date version of this critical networking library.

Highlights

  • Security Upgrade: This pull request performs a security upgrade for the urllib3 package.
  • Version Bump: The urllib3 dependency is updated from version 2.0.7 to 2.6.3.
  • Vulnerability Fix: This upgrade addresses 1 identified security vulnerability within the project's pip dependencies.
  • File Modified: The change is contained within the requirements.txt file.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by Snyk, upgrades urllib3 from version 1.x to 2.6.3 to address a security vulnerability. While the security fix is important, this constitutes a major version upgrade for urllib3 and introduces breaking changes. My review has identified critical issues that will break your project's dependencies and test suite. Specifically, there is a dependency conflict with the selenium package, which does not support urllib3 v2.x yet. Additionally, your codebase in ietf/utils/test_runner.py uses a urllib3 API that was removed in v2.0. Due to these issues, this PR cannot be merged in its current state.

Comment thread requirements.txt
tqdm>=4.64.0
Unidecode>=1.3.4
urllib3>=1.26,<2
urllib3>=2.6.3
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The upgrade of urllib3 to version 2.x introduces breaking changes that will affect this project.

  1. Dependency Conflict with selenium: The selenium package, which is a dependency in this project (selenium>=4.0), requires urllib3~=1.26. This version constraint is not compatible with urllib3 v2.x. The latest versions of selenium still have this requirement, so upgrading urllib3 will cause a dependency conflict and break tests that rely on selenium. You can track the selenium upgrade issue here: SeleniumHQ/selenium#12011.

  2. Incompatible API Usage: The file ietf/utils/test_runner.py uses an API from urllib3 that has been removed in version 2.0. On line 128, urllib3.Retry is called with a redirect keyword argument:

    http = urllib3.PoolManager(retries=urllib3.Retry(99, redirect=False))

    This argument is no longer supported in urllib3 v2.0 and will cause a TypeError at runtime.

Given these critical issues, this pull request cannot be merged as is. It is recommended to wait until selenium supports urllib3 v2.x before proceeding with this upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants