Open
Conversation
Member
|
Hi @joshdarby – could you please resolve the conflicts here? |
Collaborator
|
@adekbadek You or another Automattician will need to resolve conflicts on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This pull request makes the following changes:
Email Articlebutton in the republish modal, next toCopy to Clipboard, to allow users to email the article content and pixel in this format:$hide_republication_widget_by_filter = false;as a default before applying thehide_republication_widgetfilter, because of "Hide Republish Button" checkbox on posts shows "The Republication sharing widget on this post is programatically disabled..." message for filter only #67Why
For #68 (not sure why I named this branch 27-* 🤦♂), #67
Testing/Questions
Features that this PR affects:
Hide Republication Widgetmetabox on post editorQuestions that need to be answered before merging:
largo_post_social_linksformats the email sharing linkSteps to test this PR:
Email functionality:
Email ArticleHide Republication Widget metabox:
Hide the Republication sharing widget on this post?to be trueThe Republication sharing widget on this post is programatically disabled through the hide_republication_widget filter.warning.