This repository was archived by the owner on Aug 18, 2026. It is now read-only.
fix: add project-level .eslintrc.js to align lint setup - #340
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adds a project-level ESLint configuration so npm run lint:js uses the newspack-scripts ESLint rules (instead of falling back to @wordpress/scripts defaults), aligning this repo’s lint setup with other Newspack projects.
Changes:
- Add a root
.eslintrc.jsthat extendsnewspack-scripts’ ESLint config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
chickenn00dle
approved these changes
Jun 3, 2026
Contributor
Author
|
Thanks @chickenn00dle! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR adds a project-level
.eslintrc.js, following the same format that newspack-plugin, newspack-blocks, and newspack-popups use. This repo was missing it, which meantnpm run lint:jswas falling back to@wordpress/scripts's default config instead ofnewspack-scripts.This fixes an issue that came up in #320, where a trunk merge caused a peer-dep error in CI. Getting the repo matching other Newspack ones seemed like the safest fix.
How to test the changes in this Pull Request:
npm cito install deps.npm run build.npm run lint:js--legacy-peer-depsto get the install to work.