Skip to content

feat: setup phpunit#262

Merged
adekbadek merged 6 commits intoAutomattic:trunkfrom
Takshil-Kunadia:feat/setup-phpunit
Jul 23, 2025
Merged

feat: setup phpunit#262
adekbadek merged 6 commits intoAutomattic:trunkfrom
Takshil-Kunadia:feat/setup-phpunit

Conversation

@Takshil-Kunadia
Copy link
Copy Markdown
Contributor

@Takshil-Kunadia Takshil-Kunadia commented Jul 18, 2025

Changes proposed in this Pull Request:

Closes partially https://app.asana.com/1/26890605006346/project/1210562189110460/task/1210813694020525 .

Noticed PHPUnit not set up like other repos, this PR sets up running PHPUnit like other repos. Although there are no steps.

How to test the changes in this Pull Request:

  1. Run vendor/bin/phpunit on trunk.
  2. Notice missing phpunit setup though xml dist is present.
  3. Checkout this branch and run vendor/bin/phpunit.
  4. Check test sample running and passing

@Takshil-Kunadia Takshil-Kunadia marked this pull request as ready for review July 22, 2025 14:15
@Takshil-Kunadia Takshil-Kunadia requested a review from a team as a code owner July 22, 2025 14:15
Copy link
Copy Markdown
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a complete setup, at least one real test should be added, and a test step added in CircleCI config. As it is, this PR does not add any value.

@Takshil-Kunadia
Copy link
Copy Markdown
Contributor Author

Takshil-Kunadia commented Jul 23, 2025

Hi @adekbadek makes sense! I've added simple tests for the widget. But it looks like this repo isn't currently setup to run CircleCI pipeline on forked PR, so the jobs aren’t running on PRs. could you assist here? TIA 🙇

@adekbadek
Copy link
Copy Markdown
Member

@Takshil-Kunadia – I've updated the setting, try pushing an empty commit to trigger the build.

@Takshil-Kunadia
Copy link
Copy Markdown
Contributor Author

Thanks! @adekbadek works like a charm 🙇

@adekbadek adekbadek merged commit d9cd243 into Automattic:trunk Jul 23, 2025
2 checks passed
@matticbot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.6.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants