Skip to content

Consistent visibility of "Hide Republish Button" checkbox#172

Merged
adekbadek merged 1 commit intomasterfrom
fix/hide-republish-checkbox
Feb 24, 2023
Merged

Consistent visibility of "Hide Republish Button" checkbox#172
adekbadek merged 1 commit intomasterfrom
fix/hide-republish-checkbox

Conversation

@gamebits
Copy link
Copy Markdown

Updates code that determines whether Republication Tracker Tool's checkbox is shown in the post editor.

Changes proposed in this Pull Request:

The checkbox is currently visible only on alternating views of the post editor, with its settings getting lost in between. Closes #67 & #170.

How to test the changes in this Pull Request:

  1. Create a post and check the "Hide the Republication sharing widget on this post?" box in the post settings.
  2. Publish the post.
  3. View the post on the frontend. Observe that the republication widget is not present.
  4. Click "Edit Post".
  5. Observe that the checkbox has been replaced with the notice "The Republication sharing widget on this post is programatically disabled through the hide_republication_widget filter. Read more about this filter." (This is a known issue: "Hide Republish Button" checkbox on posts shows "The Republication sharing widget on this post is programatically disabled..." message for filter only #67)
  6. Click "Update".
  7. View the post on the frontend. Observe that the republication widget is now present.
  8. Switch to this branch. The checkbox is now always visible, and the setting is preserved between edits.

Updates code that determines whether Republication Tracker Tool's checkbox is shown in the post editor. Closes #67 & #170.
@gamebits gamebits requested a review from a team as a code owner February 21, 2023 19:16
@adekbadek adekbadek merged commit 9d1658a into master Feb 24, 2023
@adekbadek adekbadek deleted the fix/hide-republish-checkbox branch February 24, 2023 10:18
@adekbadek
Copy link
Copy Markdown
Member

Thanks @gamebits !

matticbot pushed a commit that referenced this pull request Mar 14, 2023
## [1.3.2-alpha.1](v1.3.1...v1.3.2-alpha.1) (2023-03-14)

### Bug Fixes

* consistent visibility of "Hide Republish Button" checkbox ([#172](#172)) ([9d1658a](9d1658a)), closes [#67](#67) [#170](#170)
* force alpha build ([e55763c](e55763c))
@matticbot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.3.2-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 14, 2023
## [1.3.2](v1.3.1...v1.3.2) (2023-03-14)

### Bug Fixes

* consistent visibility of "Hide Republish Button" checkbox ([#172](#172)) ([9d1658a](9d1658a)), closes [#67](#67) [#170](#170)
* force alpha build ([e55763c](e55763c))
@matticbot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Hide Republish Button" checkbox on posts shows "The Republication sharing widget on this post is programatically disabled..." message for filter only

3 participants