Skip to content

update coherence forward/backward #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 22, 2021
Merged

update coherence forward/backward #96

merged 8 commits into from
Jun 22, 2021

Conversation

ludwigVonKoopa
Copy link
Collaborator

No description provided.

@ludwigVonKoopa
- changed log format, too many tabs
0834ed2 
- adding more logs
- change generator time step on GridCollection, to work it needed more files than necessary.
- added coherence computation
@ludwigVonKoopa
Merge branch 'master' into validation_particle
fe6d3da
@ludwigVonKoopa
correction of example
fe79f1b
AntSimi
AntSimi requested changes Jun 18, 2021
View reviewed changes
Copy link
Owner

@AntSimi AntSimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some warning with flake8
./src/py_eddy_tracker/observations/network.py:1476:128: E501 line too long (139 > 127 characters)
./src/py_eddy_tracker/observations/network.py:1539:128: E501 line too long (139 > 127 characters)
./examples/07_cube_manipulation/pet_fsle_med.py:30:56: W291 trailing whitespace
./examples/16_network/pet_follow_particle.py:19:1: F401 'py_eddy_tracker.poly.group_obs' imported but unused

@ludwigVonKoopa
Copy link
Collaborator Author

better create_particles

some differences exists with new version, as old version sometimes created double particles (2 different particles with same lon/lat).
Bounding box were squared and chosen a little bit over min/max, so if 2 eddy were close enough and with proper shape, there was chances to create double particles

@ludwigVonKoopa ludwigVonKoopa merged commit 6921457 into AntSimi:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntSimi AntSimi AntSimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludwigVonKoopa @AntSimi