Validation particle #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add shift_files to GridCollection change heigth to height correct FIXME in function documentation correct tests
problem when indices is on edge of datas
AntSimi
requested changes
May 12, 2021
AntSimi
requested changes
May 12, 2021
src/py_eddy_tracker/dataset/grid.py
Outdated
| new.datasets.append((t, d)) | ||
| return new | ||
|
|
||
| def shift_files(self, t, filename, x_name, y_name, indexs, heigth): |
Owner
There was a problem hiding this comment.
Maybe add default value to index and height? And maybe kwargs directly to regular grid
Collaborator
Author
There was a problem hiding this comment.
ok for default values, but what do you mean by kwargs directly to regular grid ?
Owner
There was a problem hiding this comment.
Lot of those arguments are not used by method just transfer to another one, so maybe we could **kwargs to be transparent
move particle_candidate in groups add default values for shift_files mistake with get_uv_quad correction still in comments change delta_t to n_days correct whitespaces
AntSimi
requested changes
May 14, 2021
Owner
AntSimi
left a comment
AntSimi
left a comment
There was a problem hiding this comment.
When you modify example, you may run notebooks/README.md to update ipynb for binder use
Owner
|
https://github.com/AntSimi/py-eddy-tracker/pull/87/checks#step:6:22, look here there are some new warning |
sorting imports adding notebooks for binder adding kwargs to shift_files correction of new warnings done
AntSimi
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.