Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
-minor english
  • Loading branch information
CoriPegliasco committed Apr 6, 2021
commit d883b484acf7677adc04c820078f6ede07f57a71
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ def cost_function(records_in, records_out, distance):
return distance

def mask_function(self, other, distance):
"""We mask link with ellips and ratio"""
# Compute Parameter of ellips
"""We mask link with ellipse and ratio"""
# Compute Parameter of ellipse
minor, major = 1.05, 1.5
y = self.basic_formula_ellips_major_axis(
y = self.basic_formula_ellipse_major_axis(
self.lat, degrees=True, c0=minor, cmin=minor, cmax=major, lat1=23, lat2=5
)
# mask from ellips
# mask from ellipse
mask = self.shifted_ellipsoid_degrees_mask(
other, minor=minor, major=y # Minor can be bigger than major??
)
Expand Down
8 changes: 1 addition & 7 deletions src/py_eddy_tracker/observations/network.py
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,6 @@ def relatives(self, obs, order=2):
else:
segments_connexion[seg][0] = i_slice


if i_p != -1:

if p_seg not in segments_connexion:
Expand All @@ -531,12 +530,7 @@ def relatives(self, obs, order=2):
segments_connexion[seg][1].append(n_seg)
segments_connexion[n_seg][1].append(seg)


i_obs = (
[obs]
if not hasattr(obs, "__iter__")
else obs
)
i_obs = [obs] if not hasattr(obs, "__iter__") else obs
import numpy as np

distance = zeros(segment.size, dtype=np.uint16) - 1
Expand Down
20 changes: 10 additions & 10 deletions src/py_eddy_tracker/observations/observation.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def shifted_ellipsoid_degrees_mask2(lon0, lat0, lon1, lat1, minor=1.5, major=1.5
# Focal
f_right = lon0
f_left = f_right - (c - minor)
# Ellips center
# Ellipse center
x_c = (f_left + f_right) * 0.5

nb_0, nb_1 = lat0.shape[0], lat1.shape[0]
Expand Down Expand Up @@ -1248,7 +1248,7 @@ def shifted_ellipsoid_degrees_mask(self, other, minor=1.5, major=1.5):
)

def fixed_ellipsoid_mask(
self, other, minor=50, major=100, only_east=False, shifted_ellips=False
self, other, minor=50, major=100, only_east=False, shifted_ellipse=False
):
dist = self.distance(other).T
accepted = dist < minor
Expand All @@ -1272,13 +1272,13 @@ def fixed_ellipsoid_mask(
)

lon_self = self.lon[index_self]
if shifted_ellips:
x_center_ellips = lon_self - (major - minor) / 2
if shifted_ellipse:
x_center_ellipse = lon_self - (major - minor) / 2
else:
x_center_ellips = lon_self
x_center_ellipse = lon_self

lon_left_f = x_center_ellips - f_degree
lon_right_f = x_center_ellips + f_degree
lon_left_f = x_center_ellipse - f_degree
lon_right_f = x_center_ellipse + f_degree

dist_left_f = distance(
lon_left_f,
Expand All @@ -1302,7 +1302,7 @@ def fixed_ellipsoid_mask(
return accepted.T

@staticmethod
def basic_formula_ellips_major_axis(
def basic_formula_ellipse_major_axis(
lats, cmin=1.5, cmax=10.0, c0=1.5, lat1=13.5, lat2=5.0, degrees=False
):
"""Give major axis in km with a given latitude"""
Expand Down Expand Up @@ -2054,8 +2054,8 @@ def contains(self, x, y, intern=False):
:rtype: array[int32]
"""
xname, yname = self.intern(intern)
m = ~ (isnan(x) + isnan(y))
i = -ones(x.shape, dtype='i4')
m = ~(isnan(x) + isnan(y))
i = -ones(x.shape, dtype="i4")
i[m] = poly_indexs(x[m], y[m], self[xname], self[yname])
return i

Expand Down
4 changes: 2 additions & 2 deletions src/py_eddy_tracker/poly.py
Original file line number Diff line number Diff line change
Expand Up @@ -522,9 +522,9 @@ def fit_circle(x, y):


@njit(cache=True)
def fit_ellips(x, y):
def fit_ellipse(x, y):
r"""
From a polygon, function will fit an ellips.
From a polygon, function will fit an ellipse.

Must be call with local coordinates (in m, to get a radius in m).

Expand Down